» SmaugMuds » Bugfix Lists » AFKMud Bugfix List » AFKMud Bug Archive » [Bug] Port numbers sometimes ...
[Bug] Port numbers sometimes show up in logs with negative values
< Newer Topic
:: Older Topic >
AFKMud 1.77
Pages:<< prev 1 next >>
#1 Sep 30, 2006 11:43 pm
Black Hand
GroupAdministrators
Posts3,685
JoinedJan 1, 2002
Bug: Port numbers sometimes show up in logs with negative values
Danger: Trivial - Display only bug.
Discovered in: AFKMud 1.77
Found by: Remcon
Fixed by: Remcon
---
comm.c, nanny
Locate:
Change to:
This is a very subtle one to spot, but it makes all the difference when displaying the value. %hd is the formatting tag for a signed short, while %d is the formatting tag for an int. Since port numbers can go to 65535, a signed short isn't the proper size to display it.
Danger: Trivial - Display only bug.
Discovered in: AFKMud 1.77
Found by: Remcon
Fixed by: Remcon
---
comm.c, nanny
Locate:
log_printf_plus( LOG_COMM, LEVEL_KL, "Incoming connection: %s, port %hd.", d->host, d->port );
Change to:
log_printf_plus( LOG_COMM, LEVEL_KL, "Incoming connection: %s, port %d.", d->host, d->port );
This is a very subtle one to spot, but it makes all the difference when displaying the value. %hd is the formatting tag for a signed short, while %d is the formatting tag for an int. Since port numbers can go to 65535, a signed short isn't the proper size to display it.
Pages:<< prev 1 next >>