Login
User Name:

Password:



Register

Forgot your password?
 void nanny_get_new_race -- comm.c
Mar 13, 2025 7:08 am
By Elwood
IPv6
Jan 25, 2025 10:45 pm
By Samson
mudstrlcpy and mudstrlcat
Jan 18, 2025 5:23 pm
By Samson
I3 and IMC
Jan 17, 2025 9:35 pm
By Samson
AFKMud 2.5.1
Jan 17, 2025 2:22 pm
By Samson
SmaugFUSS 1.9.7
Author: Various
Submitted by: Samson
AFKMud 2.5.1
Author: AFKMud Team
Submitted by: Samson
Kayle's Weather Code for AFKMud
Author: Kayle
Submitted by: Samson
AFKMud 2.5.0
Author: AFKMud Team
Submitted by: Samson
SWFotEFUSS 1.5.2
Author: Various
Submitted by: Samson
Users Online
Anthropic, Meta, Bing, Bytespider

Members: 0
Guests: 12
Stats
Files
Topics
Posts
Members
Newest Member
503
3,812
19,720
592
BiancaLowr

» SmaugMuds » Bugfix Lists » SWR FUSS Bugfix List » [Bug] Setplanet filename can ...
Forum Rules | Mark all | Recent Posts

[Bug] Setplanet filename can corrupt planet files
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Jan 2, 2009 1:15 pm   
Go to the top of the page
Go to the bottom of the page

InfiniteAxis
Off the Edge of the Map
GroupAdministrators
Posts1,199
JoinedMar 21, 2006

 
Bug: Setplanet filename can corrupt planet files.
Danger: High - Planet files might get deleted or corrupted.
Found by: Keberus
Fixed by: Keberus

---


planets.c, do_setplanet

Find:
   if( !strcmp( arg2, "filename" ) )
   {
      DISPOSE( planet->filename );
      planet->filename = str_dup( argument );
      send_to_char( "Done.\r\n", ch );
      save_planet( planet );
      write_planet_list(  );
      return;
   }


Change to:
   if( !strcmp( arg2, "filename" ) )
   {
      PLANET_DATA *tplanet;

      if( !argument || argument[0] == '\0' )
      {
         send_to_char( "You must choose a file name.\r\n", ch );
         return;
      }
      for( tplanet = first_planet; tplanet; tplanet = tplanet->next )
      {
          if( !str_cmp( tplanet->filename, argument ) )
          {
              send_to_char( "A planet with that filename already exists!\r\n", ch );
              return;
          }
      }

      DISPOSE( planet->filename );
      planet->filename = str_dup( argument );
      send_to_char( "Done.\r\n", ch );
      save_planet( planet );
      write_planet_list(  );
      return;
   }


This will make sure that you can't set the filename to nothing, as well as making sure a planet with that filename doesn't already exist.

Pages:<< prev 1 next >>