Login
User Name:

Password:



Register

Forgot your password?
void nanny_get_new_race -- comm.c
Mar 13, 2025 7:08 am
By Elwood
IPv6
Jan 25, 2025 10:45 pm
By Samson
mudstrlcpy and mudstrlcat
Jan 18, 2025 5:23 pm
By Samson
I3 and IMC
Jan 17, 2025 9:35 pm
By Samson
AFKMud 2.5.1
Jan 17, 2025 2:22 pm
By Samson
SWFotEFUSS 1.5.3
Author: Various
Submitted by: Samson
SWRFUSS 1.4.3
Author: Various
Submitted by: Samson
SmaugFUSS 1.9.8
Author: Various
Submitted by: Samson
AFKMud 2.5.2
Author: AFKMud Team
Submitted by: Samson
SmaugFUSS 1.9.7
Author: Various
Submitted by: Samson
Users Online
Anthropic, AhrefsBot, Yandex, Amazonbot, Google, Bytespider, Bing

Members: 0
Guests: 3
Stats
Files
Topics
Posts
Members
Newest Member
507
3,812
19,722
591
TracySpencer

» SmaugMuds » Bugfix Lists » SmaugFUSS Bugfix List » [Bug] Weather system uses cop...
Forum Rules | Mark all | Recent Posts

[Bug] Weather system uses copy of old URANGE macro
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Mar 10, 2010 6:40 pm   
Go to the top of the page
Go to the bottom of the page

InfiniteAxis
Off the Edge of the Map
GroupAdministrators
Posts1,199
JoinedMar 21, 2006

 
Bug: Weather system uses copy of old URANGE macro.
Danger: Medium - Could result in bogus math and things returning wrong..
Found by: Kayle
Fixed by: Kayle

---

weather.h

Find and remove the WRANGE macro.

weather.c, ApplyDeltaChanges
Find:
         //Here we actually apply the changes making sure they stay within specific bounds
         cell->temperature	= WRANGE( -30, cell->temperature + delta->temperature, 100 );
         cell->pressure		= WRANGE( 0, cell->pressure + delta->pressure, 100 );
         cell->cloudcover    = WRANGE( 0, cell->cloudcover + delta->cloudcover, 100 );
         cell->energy		= WRANGE( 0, cell->energy + delta->energy, 100 );
         cell->humidity		= WRANGE( 0, cell->humidity + delta->humidity, 100 );
         cell->precipitation = WRANGE( 0, cell->precipitation + delta->precipitation, 100 );
         cell->windSpeedX	= WRANGE( -100, cell->windSpeedX + delta->windSpeedX, 100 );
         cell->windSpeedY	= WRANGE( -100, cell->windSpeedY + delta->windSpeedY, 100 );


Replace with:
         //Here we actually apply the changes making sure they stay within specific bounds
         cell->temperature = URANGE( -30, cell->temperature + delta->temperature, 100 );
         cell->pressure = URANGE( 0, cell->pressure + delta->pressure, 100 );
         cell->cloudcover = URANGE( 0, cell->cloudcover + delta->cloudcover, 100 );
         cell->energy = URANGE( 0, cell->energy + delta->energy, 100 );
         cell->humidity = URANGE( 0, cell->humidity + delta->humidity, 100 );
         cell->precipitation = URANGE( 0, cell->precipitation + delta->precipitation, 100 );
         cell->windSpeedX = URANGE( -100, cell->windSpeedX + delta->windSpeedX, 100 );
         cell->windSpeedY = URANGE( -100, cell->windSpeedY + delta->windSpeedY, 100 );


This was an attempt to make the system as reliant on the codebase as possible but ended up just causing issues. So we'll just avoid those issues by using the urange call from the codebase.

Pages:<< prev 1 next >>