Login
User Name:

Password:



Register

Forgot your password?
do_advance
Jun 27, 2026 10:32 am
By Remcon
Time spamming LOP1.6
Jun 17, 2026 4:03 pm
By Remcon
A Bash Startup Script
Feb 7, 2026 3:49 pm
By eldhamud
Force Skills
Jan 1, 2026 3:58 pm
By Elwood
Overland with Bitmaps
Jul 4, 2025 11:57 pm
By Samson
SillyMUD 1.2a
Author: J. Brothers, J. Sievert, et al
Submitted by: Samson
SillyMUD 1.1b
Author: J. Brothers, J. Sievert, et al
Submitted by: Samson
SWFotEFUSS 1.5.3
Author: Various
Submitted by: Samson
SWRFUSS 1.4.3
Author: Various
Submitted by: Samson
SmaugFUSS 1.9.8
Author: Various
Submitted by: Samson
Users Online
Anthropic

Members: 0
Guests: 39
Stats
Files
Topics
Posts
Members
Newest Member
512
3,813
19,727
593
TrinidadTr

» SmaugMuds » Bugfix Lists » SmaugFUSS Bugfix List » [Bug] Weather system uses cop...
Forum Rules | Mark all | Recent Posts

[Bug] Weather system uses copy of old URANGE macro
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Mar 10, 2010 6:40 pm   
Go to the top of the page
Go to the bottom of the page

InfiniteAxis
Off the Edge of the Map
GroupAdministrators
Posts1,199
JoinedMar 21, 2006

 
Bug: Weather system uses copy of old URANGE macro.
Danger: Medium - Could result in bogus math and things returning wrong..
Found by: Kayle
Fixed by: Kayle

---

weather.h

Find and remove the WRANGE macro.

weather.c, ApplyDeltaChanges
Find:
         //Here we actually apply the changes making sure they stay within specific bounds
         cell->temperature	= WRANGE( -30, cell->temperature + delta->temperature, 100 );
         cell->pressure		= WRANGE( 0, cell->pressure + delta->pressure, 100 );
         cell->cloudcover    = WRANGE( 0, cell->cloudcover + delta->cloudcover, 100 );
         cell->energy		= WRANGE( 0, cell->energy + delta->energy, 100 );
         cell->humidity		= WRANGE( 0, cell->humidity + delta->humidity, 100 );
         cell->precipitation = WRANGE( 0, cell->precipitation + delta->precipitation, 100 );
         cell->windSpeedX	= WRANGE( -100, cell->windSpeedX + delta->windSpeedX, 100 );
         cell->windSpeedY	= WRANGE( -100, cell->windSpeedY + delta->windSpeedY, 100 );


Replace with:
         //Here we actually apply the changes making sure they stay within specific bounds
         cell->temperature = URANGE( -30, cell->temperature + delta->temperature, 100 );
         cell->pressure = URANGE( 0, cell->pressure + delta->pressure, 100 );
         cell->cloudcover = URANGE( 0, cell->cloudcover + delta->cloudcover, 100 );
         cell->energy = URANGE( 0, cell->energy + delta->energy, 100 );
         cell->humidity = URANGE( 0, cell->humidity + delta->humidity, 100 );
         cell->precipitation = URANGE( 0, cell->precipitation + delta->precipitation, 100 );
         cell->windSpeedX = URANGE( -100, cell->windSpeedX + delta->windSpeedX, 100 );
         cell->windSpeedY = URANGE( -100, cell->windSpeedY + delta->windSpeedY, 100 );


This was an attempt to make the system as reliant on the codebase as possible but ended up just causing issues. So we'll just avoid those issues by using the urange call from the codebase.

Pages:<< prev 1 next >>